feat(components): add PopoverButton
(@beta
)
#1529
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces a new
PopoverButton
(@beta
), which is a wrapper around thePopover
primitive. It handles focus-locking, opening, closing, auto-focus, setting appropriate ARIA attributes, and more. The followingPopoverProps
are omitted, replaced, or added:content
: replaced withrenderContent
to allow providing values in the render callback (isOpen
).open
: omitted, as the open state is controlled internally by thePopoverButton
.referenceElement
: omitted, as the rendered button is always the reference.children
: omitted, as the rendered button will be the children.ariaHasPopUp
: added to ensure that this value is included in the rendered button for a11y.Example 1:
Example 2: